A market forecaster has been buzzing about a generational buying opportunity in stocks. One long-time market bear disagrees.